feat(world-builder): register uploaded graphics and extend palette schemas (#6) - #130
Conversation
Code Review ✅ Approved 2 resolved / 2 findingsRegisters uploaded custom PNG assets and extends palette schemas for the world builder, addressing missing authentication on the palette endpoint and race conditions in upsertPaletteEntry. ✅ 2 resolved✅ Security: GET /admin/game-data/maps/:mapNum/palette lacks authentication
✅ Bug: Concurrent upsertPaletteEntry can overwrite existing palette rows
OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change the behavior for this request:
Important Your trial ends in 7 days — upgrade now to keep code review, CI analysis, auto-apply, custom automations, and more. Was this helpful? React with 👍 / 👎 | Gitar |
|
Dejo esta abierta de las cuatro (#130, #131, #132, #133), porque es la unica cuyo titulo describe el bulto real del diff: las ~550 lineas de Dos cosas antes de retomarla: Quedo en conflicto. Se mergeo #109 (Stage 4 del editor), que reescribio Lo que no es world-builder va aparte. El apagado ordenado, la penalizacion por sesion doble y las variables de SES son tres cambios distintos que viajaban de polizon en este diff. Cada uno merece su PR, con su diff y nada mas. El apagado ordenado ya lo tenes asi en #48, que esta limpia y mergeable: ese es el formato que conviene.
|
Closes #6
Summary of Changes
Bridges uploaded custom PNG assets with the game engine runtime, allowing uploaded graphics to be resolved by client renderers and assigned into dynamic map palettes.
Features & Deliverables
>= 1,000,000, preventing collision with legacy original engine graphics (1..320,151).GET /graphics/:grhIndex/metadatareturning frame count, dimension, offset, and URL metadata for engine compatibility.game_map_palette_overridestable inapi/schema.sqland endpointsPUT /admin/game-data/maps/:mapNum/palette&GET /admin/game-data/maps/:mapNum/palette.api/src/tests/worldBuilder_palette.integration.test.ts.